Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration templating #1817

Closed
aviramha opened this issue Aug 20, 2023 · 2 comments · Fixed by #1824
Closed

Configuration templating #1817

aviramha opened this issue Aug 20, 2023 · 2 comments · Fixed by #1824
Assignees

Comments

@aviramha
Copy link
Member

Right now our configuration supports constant values, but some users asked for templating features, so they could have a config file that is mutated by the specific run.
I think maybe we should start with adding ability to use environment variables, so for example have

{
  "target": {
    "path": "{DEPLOYMENT_NAME}",
    "namespace": "{NAMESPACE_NAME}"
  }
}

then user can set DEPLOYMENT_NAME and fetch it from env.

@aviramha
Copy link
Member Author

aviramha commented Aug 23, 2023

@meowjesty
Copy link
Member

All 3 requirements have been merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants