Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capability to modify the local listen address for mirrord #2319

Closed
danielloader opened this issue Mar 24, 2024 · 2 comments · Fixed by #2364
Closed

Capability to modify the local listen address for mirrord #2319

danielloader opened this issue Mar 24, 2024 · 2 comments · Fixed by #2364
Labels
easy enhancement New feature or request

Comments

@danielloader
Copy link

danielloader commented Mar 24, 2024

Feature request born out of the issue comment found here: #1658 (comment)

I'd like to be able to bind mirrord to 0.0.0.0 so I can expose a mirrord tunnelled application from inside a local container.

This would permit containers in the same network namespace or the host OS applications if the container is port mapped, access to the kubernetes internal network via proxy services, e.g. tinyproxy, microsocks, squid etc.

I'd like to configure this via CLI arguments in addition to the mirrord configuration file.

Where to begin?

Please refer to the CONTRIBUTING.md file

@danielloader danielloader added the enhancement New feature or request label Mar 24, 2024
@aviramha
Copy link
Member

I tried to remember why we did this change (we always bind localhost instead of real address) and the case is when user tries to bind remote ip, and then it fails when listening locally. I think the change should be to check if localhost or 0.0.0.0 and in that case listen locally on same, else fallback to localhost

@danielloader
Copy link
Author

danielloader commented Mar 24, 2024

I'm happy if the default current behaviour is retained and a more explicit flag is needed to get this potentially more dangerous behaviour, rather than some auto-magic logic to ascertain uncertain intent. Though if you think it's a bug that the wrapped binary binds to 0.0.0.0 and mirrord doesn't also do the same, I'm happy to treat it as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy enhancement New feature or request
Projects
None yet
2 participants