Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http path filter runs on path only #2551

Closed
aviramha opened this issue Jun 26, 2024 · 0 comments · Fixed by #2552
Closed

http path filter runs on path only #2551

aviramha opened this issue Jun 26, 2024 · 0 comments · Fixed by #2552

Comments

@aviramha
Copy link
Member

http path filter runs on the path only:
image

            Self::Path(filter) => {
                let path = request.uri().path();
                filter
                    .is_match(path)
                    .inspect_err(|error| {
                        tracing::error!(path, ?error, "Error while matching path");
                    })
                    .unwrap_or(false)
            }

but actually it'd be more useful to run on the entire uri - I guess naming might confuse but I also guess that most users would assume path includes the query params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant