-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRD Status: Implement L2 Service Status #2158
Comments
I'd love to implement this |
thanks! assigned, let us know if you need any help in #metallb-dev or here |
The very first problem I met is:
On the other hand, it seems not possible to init a kubebuilder project based on a non empty folder.
So now there seems no way to generate the xxx_type.go ? I wonder how was the xxx_types.go written before? |
I honestly don't remember how it was done (and I did it). The thing is, metallb is kind of a frankenstein that started before kubebuilder (or controller runtime) was a thing. Lately, we introduced CRDs and the controller-runtime based controllers in place of the existing configmap. If I were you, I'd just copy one existing file and adjust it, doesn't seem a big deal. |
@lwabish did you manage to sort it out? |
I think so. I have finished coding and start working on testing them. |
Is your feature request related to a problem?
https://github.com/metallb/metallb/blob/main/design/crd-status.md
Describe the solution you'd like
As described in https://github.com/metallb/metallb/blob/main/design/crd-status.md#service-announcement---l2 we want to implement the
ServiceL2Status
resourceAdditional context
No response
I've read and agree with the following
The text was updated successfully, but these errors were encountered: