Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This action should be triggered and receive inputs via workflow_dispatch #3

Closed
rekmarks opened this issue Apr 30, 2021 · 2 comments
Closed

Comments

@rekmarks
Copy link
Member

rekmarks commented Apr 30, 2021

We should follow the example of MetaMask/action-monorepo-release-pr.

on:
    workflow_dispatch:
        inputs:
            release-type:
                description: 'A SemVer version diff, i.e. major, minor, patch, prerelease etc. Mutually exclusive with "release-version".'
                required: false
            release-version:
                description: 'A specific version to bump to. Mutually exclusive with "release-type".'
                required: false
@shanejonas
Copy link
Contributor

The outcome of our meeting around this was that although it would be nice to have both, workflow_dispatch is preferred and having both would complicate this action and workflow example

@rekmarks rekmarks changed the title Should this action receive inputs via workflow_dispatch instead of the branch name? This action should be triggered and receive inputs via workflow_dispatch May 3, 2021
@rekmarks
Copy link
Member Author

rekmarks commented May 5, 2021

This was done.

@rekmarks rekmarks closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants