Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to EIP-1193 provider changes #231

Closed
mcmire opened this issue Mar 21, 2024 · 0 comments · Fixed by #252
Closed

Adapt to EIP-1193 provider changes #231

mcmire opened this issue Mar 21, 2024 · 0 comments · Fixed by #252
Assignees
@kanthesha
Labels
team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Mar 21, 2024 •
edited
Loading

After SafeEventEmitterProvider is updated to support EIP-1193 and a new version of @metamask/eth-json-rpc-provider is released, we should adapt to the changes:

  • We should bump @metamask/eth-json-rpc-provider to rely on the new changes.
  • At that point, calling sendAsync will be deprecated; we should use request instead.
    • There are only a couple places in the implementation where we are using sendAsync.
    • However, there are ~20 references in the tests. In particular, the tests make use of a provider whose sendAsync method is mocked. We need to update the helper code to mock request instead.
@mcmire mcmire changed the title Use request on provider instead of sendAsync to make network requests Adapt to EIP-1193 provider changes Mar 22, 2024
@kanthesha kanthesha self-assigned this Jul 3, 2024
@kanthesha kanthesha mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanthesha kanthesha

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adapt to eip-1193 provider changes MetaMask/eth-block-tracker
2 participants
@mcmire @kanthesha