Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not install from ethereumjs-abi as it does not contain a package.json file. #135

Closed
StillFantastic opened this issue Mar 21, 2021 · 2 comments

Comments

@StillFantastic
Copy link

When I run npm install, I got and error message:

npm ERR! Could not install from "node_modules/eth-sig-util/ethereumjs-abi@git+https:/github.com/ethereumjs/ethereumjs-abi.git" as it does not contain a package.json file.

In my package-lock.json's eth-sig-util section, I see:

    "eth-sig-util": {
      "version": "1.4.2",
      "resolved": "https://registry.npmjs.org/eth-sig-util/-/eth-sig-util-1.4.2.tgz",
      "integrity": "sha1-jZWCAsftuq6Dlwf7pvCf8ydgYhA=",
      "requires": {
        "ethereumjs-abi": "ethereumjs-abi@git+https://github.com/ethereumjs/ethereumjs-abi.git",
        "ethereumjs-util": "^5.1.1"
      },

It works If I delete ethereumjs-abi@ before git+https, but it shows up again if I run npm install, not sure if it is a bug?

@just-toby
Copy link

just-toby commented Apr 1, 2021

is this a duplicate of #134 ? that issue refers to ethereumjs-abi being deprecated, which i assumed is the reason this package is causing npm install to fail.

fwiw i'm running into this issue too. if anyone has advice for how to avoid the failure i'd appreciate it. this package is like 2-3 downstream from my project so kinda hard to fix directly on my end.

@Gudahtt
Copy link
Member

Gudahtt commented Jul 13, 2021

Thanks for the report! Unfortunately we don't support v1.x anymore. Please update to v2 or v3 - this problem should be fixed in both v2.5.4 and v3.0.1.

@Gudahtt Gudahtt closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants