Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve connecting via EIP-6963 content #1197

Closed
alexandratran opened this issue Mar 7, 2024 · 1 comment
Closed

Improve connecting via EIP-6963 content #1197

alexandratran opened this issue Mar 7, 2024 · 1 comment
Assignees
Labels
tech-writing Requires updates to documentation content. wallet Related to wallet content.

Comments

@alexandratran
Copy link
Contributor

alexandratran commented Mar 7, 2024

Now that EIP-6963 is the recommended method of connecting to MetaMask, and we also want to deprioritize the SDK content, some of our documentation structure and code samples are outdated. This issue is to:

  • Remove the Quickstart section
  • Update the Detect wallet section:
    • Rename it to "Connect to MetaMask"
    • Recommend EIP-6963 as the primary method for connecting, whether directly or via third-party library
    • Add EIP-6963 code examples for vanilla JS
    • We no longer recommend detecting MetaMask via @metamask/detect-provider (should this content be removed completely?)
  • Audit and update code samples throughout the docs that use window.ethereum
  • Remove Access a user's MetaMask provider

Other places that may require related updates:

@alexandratran
Copy link
Contributor Author

Fixed by #1214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-writing Requires updates to documentation content. wallet Related to wallet content.
Projects
None yet
Development

No branches or pull requests

1 participant