Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Typescript type coverage UI Folder part 4 #10205

Open
1 of 9 tasks
tommasini opened this issue Jul 1, 2024 · 0 comments
Open
1 of 9 tasks

Chore: Typescript type coverage UI Folder part 4 #10205

tommasini opened this issue Jul 1, 2024 · 0 comments

Comments

@tommasini
Copy link
Contributor

What is this about?

The following strategy to get this done without causing friction to others work will be:

Start to uncomment, commented lines at tsconfig.lint.json
Fix the flagged typescript issues by yarn lint:tsc of the following chunk of files
Revert the uncommented lines at tsconfig.lint.json
Open a PR against the issue

UI Folder part 4

     3  app/components/UI/Ramp/Views/NetworkSwitcher/NetworkSwitcher.test.tsx:275
     1  app/components/UI/Ramp/Views/NetworkSwitcher/NetworkSwitcher.tsx:143
    14  app/components/UI/Ramp/Views/Quotes/Quotes.tsx:146
     2  app/components/UI/Ramp/Views/Regions/Regions.tsx:185
     1  app/components/UI/Ramp/Views/SendTransaction/SendTransaction.tsx:271
     2  app/components/UI/ReusableModal/index.tsx:166
     2  app/components/UI/ReviewModal/index.tsx:154
     1  app/components/UI/SearchTokenAutocomplete/index.test.tsx:27
     2  app/components/UI/SearchTokenAutocomplete/index.tsx:232
     1  app/components/UI/SimulationDetails/BalanceChangeRow/BalanceChangeRow.test.tsx:12
     1  app/components/UI/SimulationDetails/BalanceChangeRow/BalanceChangeRow.tsx:49
    10  app/components/UI/SimulationDetails/SimulationDetails.test.tsx:83
     1  app/components/UI/Swaps/SwapsLiveness.ts:20
     1  app/components/UI/Tabs/index.test.tsx:31
     1  app/components/UI/TextEstimated/TextEstimated.constants.ts:9
     4  app/components/UI/Tokens/index.tsx:13
     2  app/components/UI/TransactionElement/TransactionDetails/index.test.tsx:25
     2  app/components/UI/WarningAlert/WarningAlert.tsx:39
     2  app/components/UI/WebsiteIcon/index.test.tsx:9

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant