Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] Fix TS errors in core directory #6949

Closed
Cal-L opened this issue Aug 1, 2023 · 0 comments
Closed

[TS] Fix TS errors in core directory #6949

Cal-L opened this issue Aug 1, 2023 · 0 comments
Assignees
@Cal-L
Labels
team-mobile-platform

Comments

@Cal-L
Copy link
Contributor

Cal-L commented Aug 1, 2023 •
edited

Description

Fix Typescript errors in the core directory

Technical Details

Number of errors by file

     1  app/core/GasPolling/GasPolling.test.ts:183
     3  app/core/GasPolling/GasPolling.ts:152
     1  app/core/RPCMethods/eth_sendTransaction.ts:6
     1  app/core/RPCMethods/RPCMethodMiddleware.test.ts:11
     1  app/core/RPCMethods/RPCMethodMiddleware.ts:7
     1  app/core/WalletConnect/WalletConnect.test.ts:

Acceptance Criteria

  • running yarn tsc should not show any issues in the core directory
@Cal-L Cal-L self-assigned this Sep 25, 2023
@gauthierpetetin gauthierpetetin added in-progress needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Sep 25, 2023
@Cal-L Cal-L closed this as completed Oct 11, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cal-L Cal-L

Labels
team-mobile-platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gauthierpetetin @Cal-L