Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Deeplink not properly handling error, stays loading indefinitely #7116

Closed
seaona opened this issue Sep 4, 2023 · 2 comments
Closed
Labels
Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild stale Issues that have not had activity in the last 90 days team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working

Comments

@seaona
Copy link
Contributor

seaona commented Sep 4, 2023

Describe the bug
There are certain types of Deeplinks errors that are no properly handled, making the wallet load indefinetly, instead of closing the window after the error has been thrown.

Screenshots

deeplink-error-loading.mp4

To Reproduce

  1. Go to test dapp
  2. Mint an NFT
  3. Copy the contract address
  4. Go to deeplink generator https://metamask.github.io/metamask-deeplinks/#
  5. Send ERC20
  6. Add the NFT address
  7. Add 0 decimals
  8. Add any recipient address
  9. Scan the QR code
  10. See loading indefinitely

Expected behavior
Here is an example of a case where the error is handled and the window is closed after error appears. (Whenever we pass an invalid amount)

expecterd-deeeplink-error.mp4

You can try this one scanning this QR code
Screenshot from 2023-09-04 12-06-43

Smartphone (please complete the following information):

  • Device: Pixel 6
  • OS: Android
  • App Version: v7.5.0 (1167) production

to be added after bug submission by internal support / PM
Severity

  • How critical is the impact of this bug on a user?
  • Add stats if available on % of customers impacted
  • Is this visible to all users?
  • Is this tech debt?
@seaona seaona added type-bug Something isn't working team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild labels Sep 4, 2023
@bschorchit bschorchit added team-confirmations-system DEPRECATED: please use "team-confirmations" label instead and removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead labels Sep 20, 2023
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Dec 19, 2023
Copy link
Contributor

This issue was closed because there has been no follow activity in 7 days. If you feel this was closed in error please provide evidence on the current production app in a new issue or comment in the existing issue to a maintainer. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild stale Issues that have not had activity in the last 90 days team-confirmations-system DEPRECATED: please use "team-confirmations" label instead type-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants