Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce enzyme usage in unit test by 25% - [3 of 3] #8618

Open
9 tasks
Cal-L opened this issue Feb 18, 2024 · 1 comment
Open
9 tasks

Reduce enzyme usage in unit test by 25% - [3 of 3] #8618

Cal-L opened this issue Feb 18, 2024 · 1 comment
Labels
good first issue Good for newcomers No QA Needed Apply this label when your PR does not need any QA effort. ready-for-dev team-mobile-platform

Comments

@Cal-L
Copy link
Contributor

Cal-L commented Feb 18, 2024

What is this about?

Convert the list of unit tests to use react-testing-library instead of enzyme. In total there are 53 files to convert. To make PRs easier to review and more manageable, this covers 19 test files.

Scenario

No response

Design

No response

Technical Details

Convert these files

'app/components/Views/EnterPasswordSimple/index.test.tsx',
'app/components/Views/AddBookmark/index.test.tsx',
'app/components/UI/WhatsNewModal/index.test.tsx',
'app/components/UI/SliderButton/index.test.tsx',
'app/components/UI/Screen/index.test.tsx',
'app/components/UI/ReusableModal/index.test.tsx',
'app/components/UI/BlockingActionModal/index.test.tsx',
'app/components/UI/AnimatedTransactionModal/index.test.tsx',
'app/component-library/components/Buttons/Button/variants/ButtonLink/ButtonLink.test.tsx',
'app/components/UI/WarningAlert/WarningAlert.test.tsx',
'app/component-library/components/Texts/Text/Text.test.tsx',
'app/component-library/components/Avatars/Avatar/variants/AvatarIcon/AvatarIcon.test.tsx',
'app/components/Nav/Main/index.test.tsx',
'app/components/UI/SlippageSlider/index.test.tsx',
'app/components/UI/AssetList/index.test.tsx',
'app/components/Views/TransactionsView/index.test.js',
'app/components/Views/PickComponent/index.test.tsx',
'app/components/Approvals/ApprovalModal/ApprovalModal.test.tsx',
'app/components/UI/PaymentRequest/index.test.tsx'

Threat Modeling Framework

No response

Acceptance Criteria

Unit tests for the updated files should all pass. Snapshots should not change.

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@Cal-L Cal-L added team-mobile-platform No QA Needed Apply this label when your PR does not need any QA effort. good first issue Good for newcomers labels Feb 18, 2024
@timi-codes
Copy link
Contributor

I'm working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers No QA Needed Apply this label when your PR does not need any QA effort. ready-for-dev team-mobile-platform
Projects
None yet
Development

No branches or pull requests

4 participants