Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Disclaim more clearly that the Ledger mobile integration does not support Ledger Nano S #8719

Open
plasmacorral opened this issue Feb 24, 2024 · 6 comments
Labels
Ledger Ledger hardware wallet related issue or development needs-content Needs content / copy support. regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.17.0 release-7.17.0 Issue or pull request that will be included in release 7.17.0 Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-hardware-wallets type-bug Something isn't working type-enhancement New feature or request

Comments

@plasmacorral
Copy link
Contributor

plasmacorral commented Feb 24, 2024

Describe the bug

Although we mention Ledger Nano X in the Add hardware flow, we could probably be more explicitly clear that Nano S is not supported since it lacks Bluetooth.

If the buttons are on the top of the device you will not be able to use it with MetaMask Mobile, but if the Ledger buttons are on the front of the display you may proceed.

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

  1. Setup wallet
  2. Hit the accounts drop down
  3. Select Add new account of hardware wallet
  4. Then tap Add hardware wallet
  5. Then tap Ledger
  6. Observe Nano X mentioned once on this page

Error messages or log output

No response

Version

7.17.0 RC1 build 1266

Build type

None

Device

Pixel 5a Android 14

Operating system

Android

Additional context

No response

Severity

This is an opportunity for improvement that might save time and frustration for MetaMask users that have a Ledger Nano S and may want to try and use it with the mobile client.

@plasmacorral plasmacorral added type-enhancement New feature or request Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild Ledger Ledger hardware wallet related issue or development regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead team-hardware-wallets release-7.17.0 Issue or pull request that will be included in release 7.17.0 labels Feb 24, 2024
@plasmacorral plasmacorral changed the title [Bug]: Disclaim more clearly that the Ledger mobile integration does not support Ledger Nano S [Enhancement]: Disclaim more clearly that the Ledger mobile integration does not support Ledger Nano S Feb 24, 2024
@metamaskbot metamaskbot added the type-bug Something isn't working label Feb 24, 2024
@angelcheung22 angelcheung22 added needs-content Needs content / copy support. and removed type-bug Something isn't working Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild labels Feb 27, 2024
@metamaskbot metamaskbot added the type-bug Something isn't working label Feb 27, 2024
@coreyjanssen
Copy link

@plasmacorral @angelcheung22 would one of you mind adding a screenshot of the copy in question? I'm trying to reproduce the issue on my own and can't seem to get it. Thanks!

@vivek-consensys
Copy link
Contributor

hey @coreyjanssen, here is the screenshot you requested:-

image.png

@coreyjanssen
Copy link

I'm curious if explicitly calling out Ledger Nano models is the best method of communicating this screen? Perhaps we should be agnostic in general? Thoughts on this @plasmacorral et al?

Looking for device...
Make sure to:

  1. Unlock your Ledger
  2. Install and open the Ethereum app
  3. Enable Bluetooth

Tip: If your device doesn't have Bluetooth, it can't be used with our mobile app. You can add it by using the MetaMask extension.

@angelcheung22
Copy link

@AlexJupiter any comment about above suggestion from Corey?

@angelcheung22
Copy link

deprioritised from backlog for now. come back after multiple accounts discussion

@plasmacorral
Copy link
Contributor Author

Hey, sorry I left this hanging @coreyjanssen.

Tip: If your device doesn't have Bluetooth, it can't be used with our mobile app. You can add it by using the MetaMask extension.

I guess the challenge that I foresee is that some users may not immediately recognize that their device does or does not support bluetooth. My thought was anything we can show to indicate that buttons on the front=good and buttons on the top will not work, might save users and support some time.

@gauthierpetetin gauthierpetetin added the Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ledger Ledger hardware wallet related issue or development needs-content Needs content / copy support. regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-7.17.0 release-7.17.0 Issue or pull request that will be included in release 7.17.0 Sev3-low A possible confusion or deception that is only hypothetical & has no known instances in the wild team-hardware-wallets type-bug Something isn't working type-enhancement New feature or request
Projects
Status: To be fixed
Status: To be fixed
Development

No branches or pull requests

6 participants