Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Asset's type is always ETH in the notification #8832

Closed
thanks173 opened this issue Mar 4, 2024 · 1 comment
Closed

[Bug]: Asset's type is always ETH in the notification #8832

thanks173 opened this issue Mar 4, 2024 · 1 comment
Labels
external-contributor regression-prod-7.15.0 Regression bug that was found in production in release 7.15.0 type-bug Something isn't working

Comments

@thanks173
Copy link

Describe the bug

When receiving (native) tokens, the notification always shows the assets type as ETH

Expected behavior

Display the correct asset's type, ERC20 or native

Screenshots/Recordings

307285267-976c0f53-fd09-49fb-be1a-6b9dd84d0835
This is 750 USDT incomming transaction

Steps to reproduce

  1. Send token to the wallet
  2. Wait for the notification

Error messages or log output

No response

Version

7.15.0

Build type

None

Device

iPhone

Operating system

iOS

Additional context

I created PR #8699 for this

Severity

No response
@thanks173 thanks173 added the type-bug Something isn't working label Mar 4, 2024
@thanks173 thanks173 mentioned this issue Mar 4, 2024
Closed
13 tasks
@metamaskbot metamaskbot added external-contributor regression-prod-7.15.0 Regression bug that was found in production in release 7.15.0 labels Mar 4, 2024
@seaona
Copy link
Contributor

seaona commented Mar 19, 2024

Same/Similar as #7669

@gauthierpetetin gauthierpetetin closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external-contributor regression-prod-7.15.0 Regression bug that was found in production in release 7.15.0 type-bug Something isn't working
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correct asset type in the incoming transaction notification thanks173/metamask-mobile
5 participants
@gauthierpetetin @thanks173 @metamaskbot @seaona @anaamolnar