Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to use Segment instead of Mixpanel in injectHomePageScripts in app/components/Views/BrowserTab/index.js #8843

Open
3 of 9 tasks
NicolasMassart opened this issue Mar 5, 2024 · 0 comments

Comments

@NicolasMassart
Copy link
Contributor

NicolasMassart commented Mar 5, 2024

What is this about?

Since Mobile app moved to Segment, we have to update home.metamask.io to use Segment instead of Mixpanel.
The metrics ID is injected in the web page through injectHomePageScripts in app/components/Views/BrowserTab/index.js

Scenario

No response

Design

No response

Technical Details

  • check with home page team how the dapp page can be moved to segment. Currently, analytics are using mixpanel in util/analytics.js
  • update mobile app injected code to provide the correct id to the dapp

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify): Dapp team and data team

References

https://github.com/MetaMask/dapps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant