fix: add identify metrics call at metrics instance setup #8885
Assignees
Labels
Comments
NicolasMassart
added
team-mobile-platform
release-7.18.0
NicolasMassart
added a commit
that referenced
this issue
Mar 8, 2024
13 tasks
Cal-L
added a commit
that referenced
this issue
Mar 14, 2024
## **Description** adds identify call at the end of metrics config ## **Related issues** Fixes #8885 ## **Manual testing steps** ```gherkin Feature: identify on start Scenario: fresh install Given app is a fresh installed And first screen appears Then logs should display "MetaMetrics configured with ID: [UUID]" And no event is sent Scenario: wallet created Given wallet was created And user accepted metrics And first screen appears Then logs should display "INFO IDENTIFY event saved {...}" And at least 1 event is sent ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** No IDENTIFY log at startup ### **After** <img width="500" alt="image" src="https://github.com/MetaMask/metamask-mobile/assets/4677568/2042f2fa-62a9-4bed-be61-3654ea16f581"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Cal Leung <cleun007@gmail.com>
metamaskbot
added
the
release-7.19.0
metamaskbot
pushed a commit
that referenced
this issue
Mar 14, 2024
## **Description** adds identify call at the end of metrics config ## **Related issues** Fixes #8885 ## **Manual testing steps** ```gherkin Feature: identify on start Scenario: fresh install Given app is a fresh installed And first screen appears Then logs should display "MetaMetrics configured with ID: [UUID]" And no event is sent Scenario: wallet created Given wallet was created And user accepted metrics And first screen appears Then logs should display "INFO IDENTIFY event saved {...}" And at least 1 event is sent ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** No IDENTIFY log at startup ### **After** <img width="500" alt="image" src="https://github.com/MetaMask/metamask-mobile/assets/4677568/2042f2fa-62a9-4bed-be61-3654ea16f581"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Cal Leung <cleun007@gmail.com>
cortisiko
removed
the
release-7.19.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is this about?
In segment, in order to improve user props update, identification is expected as soon as possible. We currently only do it when optin and not at app start when user is already optin.
We may miss some properties updated.
Scenario
No response
Design
No response
Technical Details
add identify in the Metametrics.configure after metametricsId is ready
Threat Modeling Framework
No response
Acceptance Criteria
Stakeholder review needed before the work gets merged
References
https://github.com/MetaMask/metamask-mobile/blob/main/app/core/Analytics/MetaMetrics.ts#L512-L529
The text was updated successfully, but these errors were encountered: