Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

do not perform lookups unless opted in #18

Closed
zzmp opened this issue Oct 20, 2021 · 2 comments
Closed

do not perform lookups unless opted in #18

zzmp opened this issue Oct 20, 2021 · 2 comments

Comments

@zzmp
Copy link
Contributor

zzmp commented Oct 20, 2021

The passed provider may provide a way to do ENS lookups, but if it does not, no lookups should be performed unless the integrator opts in. This prevents data/privacy leaking.

@zzmp
Copy link
Contributor Author

zzmp commented Oct 20, 2021

@davatar/react makes calls to alchemy for ENS resolution on chainIDs besides 1, 3, 4, 5 (code).

@carlosdp
Copy link
Contributor

I'm not sure I understand, what's the leak vector here? This library looks up ENS on mainnet (unless on a testnet with ENS deployed, where we assume we want to test with an ENS on that chain), which should be the correct behavior, even if the "connected" chain is a different one (say Polygon).

@zzmp zzmp closed this as completed Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants