Skip to content

Commit

Permalink
#5659 Add comment and mark user to notify
Browse files Browse the repository at this point in the history
metasfresh/metasfresh#5659
#5659 Picklist in Picking Terminal v2 automatically picks, but shall not
  • Loading branch information
cristinamghita committed Oct 15, 2019
1 parent 4e2cedc commit bd86772
Showing 1 changed file with 5 additions and 3 deletions.
Expand Up @@ -65,7 +65,6 @@ public class PackageablesView_PrintPicklist extends PackageablesViewBasedProcess
@Autowired
private ShipmentScheduleLockRepository locksRepo;


final private IADPInstanceDAO adPInstanceDAO = Services.get(IADPInstanceDAO.class);

@Override
Expand Down Expand Up @@ -102,7 +101,7 @@ protected String doIt()
final PackageableRow row = getSingleSelectedRow();

final ShipmentScheduleLockRequest lockRequest = createLockRequest(row);
// th eline needs to remain lokced until the user explcittly unlocks it
// the line needs to remain locked until the user explicitly unlocks it
locksRepo.lock(lockRequest);

try
Expand Down Expand Up @@ -143,10 +142,13 @@ public void run(final String localTrxName) throws Exception
productsToPickRowsRepository.createPickingCandidates(row);
}

// Throw an explicit error in order to make sure that the user sees that something went wrong
// mainly we might got some line that should not be in picking terminal
@Override
public boolean doCatch(final Throwable e) throws Throwable
{
throw AdempiereException.wrapIfNeeded(e);
throw AdempiereException.wrapIfNeeded(e)
.markUserNotified();
}

@Override
Expand Down

0 comments on commit bd86772

Please sign in to comment.