Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product lookup performance improvements #1167

Closed
teosarca opened this issue Mar 14, 2019 · 1 comment
Closed

Product lookup performance improvements #1167

teosarca opened this issue Mar 14, 2019 · 1 comment
Assignees
@teosarca
Labels
branch:master branch:release type:documentation type:enhancement

Comments

@teosarca
Copy link
Member

teosarca commented Mar 14, 2019 •
edited by metas-ts

Is this a bug or feature request?

What is the current behavior?

Which are the steps to reproduce?

What is the expected or desired behavior?

Configuration

Sysconfig de.metas.ui.web.window.descriptor.sql.ProductLookupDescriptor.DisableFullTextSearch

Disables the "full text search" for Products lookup (that one that is used on order product batch entry).

Sysconfig de.metas.ui.web.window.descriptor.LookupDescriptor.DefaultLookupSearchStartDelayMillis

Advice frontend which shall be the delay after user typed something and backend to be contracted.

AD_Table.ACTriggerLength

  • advices frontend about how many chars the search string shall be sent to backend
  • backend will return empty result if the search string length is less that configured length
  • if the configured length is less or equal to zero it shall be ignored
@teosarca teosarca self-assigned this Mar 14, 2019
teosarca added a commit to metasfresh/metasfresh that referenced this issue Mar 14, 2019
@teosarca
ProductBL.getStockingUOM: get the UOM from repo
b9054f9 
metasfresh/metasfresh-webui-api-legacy#1167
teosarca added a commit to metasfresh/metasfresh that referenced this issue Mar 14, 2019
@teosarca
make ModelTranslation maps immutable
ee70940 
metasfresh/metasfresh-webui-api-legacy#1167
teosarca added a commit to metasfresh/metasfresh that referenced this issue Mar 14, 2019
@teosarca
Update ModelCacheService.java
c4aea8b 
preload trls before returning the PO

metasfresh/metasfresh-webui-api-legacy#1167
teosarca added a commit that referenced this issue Mar 14, 2019
@teosarca
Update AvailableToPromiseAdapter.java
75e47b8 
don't load the product out of repo

#1167
teosarca added a commit to metasfresh/metasfresh that referenced this issue Mar 15, 2019
@teosarca
IADTableDAO.getTypeaheadMinLength
084e552 
metasfresh/metasfresh-webui-api-legacy#1167
teosarca added a commit to metasfresh/metasfresh that referenced this issue Mar 15, 2019
@teosarca
Create 5516190_sys_gh1167webui_DisableFullTextSearch_sysconfig.sql
5c66a7d 
metasfresh/metasfresh-webui-api-legacy#1167
teosarca added a commit that referenced this issue Mar 15, 2019
@teosarca
Update ProductLookupDescriptor.java
12c77a9 
* search by product's Value and Name (configurable)
* check & respect Product's AD_Table.ACTriggerLength

#1167
teosarca added a commit to metasfresh/metasfresh that referenced this issue Mar 16, 2019
@teosarca
Create 5516310_sys_gh1167webui_DefaultLookupSearchStartDelayMillis_sy…
e1dd3dc 
…sconfig.sql

metasfresh/metasfresh-webui-api-legacy#1167
teosarca added a commit that referenced this issue Mar 16, 2019
@teosarca
don't use deprecated API
88c7166 
#1167
teosarca added a commit that referenced this issue Mar 16, 2019
@teosarca
minor
13a171e 
#1167
teosarca added a commit that referenced this issue Mar 16, 2019
@teosarca
refactor lookups API
9de342a 
#1167
teosarca added a commit that referenced this issue Mar 16, 2019
@teosarca
LookupDescriptor: searchStringMinLength, searchStartDelay
ec6c3fb 
#1167
This was referenced Mar 16, 2019
Merged
Merged
teosarca added a commit that referenced this issue Mar 16, 2019
@teosarca
move test code out of DataEntryTabLoader
107704d 
#1167
teosarca added a commit that referenced this issue Mar 16, 2019
@teosarca
minor
1844b78 
#1167
teosarca added a commit that referenced this issue Mar 16, 2019
@teosarca
update junit test snapshot
beb9b13 
#1167
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Mar 18, 2019
@metas-ts
Update ReleaseNotes.md
e0a057d 
  * [#4959](#4959) Data entry implementation
  * [#1165](metasfresh/metasfresh-webui-api-legacy#1165) Window Layout: allow first field of a fields combo to be a dropdown
  * [#1167](metasfresh/metasfresh-webui-api-legacy#1167) Product lookup performance improvements (repsective frontend isue not yet doen)
  * [#2177](metasfresh/metasfresh-webui-frontend-legacy#2177) Support single entry view mode for Tabs
  * [#1163](metasfresh/metasfresh-webui-api-legacy#1163) Warehouse cannot be created / opening window causes error
  * [#2201](metasfresh/metasfresh-webui-frontend-legacy#2201) Attributes panel is not displayed in HU Editor
  * [#2204](metasfresh/metasfresh-webui-frontend-legacy#2204) QR Code not displayed
@teosarca teosarca mentioned this issue Mar 18, 2019
Closed
@metas-dh
Copy link
Member

Results of IT
tested in customer db

  • search only after entering the 3rd digit: OK
  • takes ~1 sec or less for searching for the complete product no. ((1.09 sec) or when setting it digit by digit (1.01 sec): OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teosarca teosarca

Labels
branch:master branch:release type:documentation type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teosarca @metas-ts @metas-dh