Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't export JSONDocument.fields if empty #277

Closed
teosarca opened this issue Mar 31, 2017 · 1 comment
Closed

Don't export JSONDocument.fields if empty #277

teosarca opened this issue Mar 31, 2017 · 1 comment

Comments

@teosarca
Copy link
Member

Is this a bug or feature request?

Bug

What is the current behavior?

Sometimes JSONDocument fields are exported to JSON as an empty array if though it's configured to @JsonInclude(JsonInclude.Include.NON_EMPTY)

Which are the steps to reproduce?

Try edit some document and line (e.g. a sales order).
Check chrome's Network tab, focus on those endpoints which are returning document changes.
In some cases you will something like

   fields : []

What is the expected or desired behavior?

Never export "fields" if empty.

@teosarca teosarca added this to the 2017-14 milestone Mar 31, 2017
teosarca added a commit that referenced this issue Mar 31, 2017
else, the @JsonInclude(JsonInclude.Include.NON_EMPTY) will not work
because by default, a field is considered empty when it's null.
@teosarca teosarca changed the title Don't export JSONDocument.fields is empty Don't export JSONDocument.fields if empty Mar 31, 2017
teosarca added a commit that referenced this issue Mar 31, 2017
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Apr 5, 2017
[#1267](#1267) Cannot open ASI editor in Swing
[#277](metasfresh/metasfresh-webui-api-legacy#277) Don't export JSONDocument.fields if empty
[#597](metasfresh/metasfresh-webui-frontend-legacy#597) cancel on "Do you really want to leave?" sends you 2 steps back
[#595](metasfresh/metasfresh-webui-frontend-legacy#595) kpi disappears when minimize
[#594](metasfresh/metasfresh-webui-frontend-legacy#594) inform users that only Chrome is currently supported on login screen
[#1222](#1222) Show orderline description only in the first column of the Jasper
[#541](metasfresh/metasfresh-webui-frontend-legacy#541) Hide new and delete included documents when they are not available.
@metas-mk metas-mk modified the milestones: 2017-16, 2017-14 Apr 9, 2017
@metas-dh
Copy link
Member

Results of IT1
tested on w101

  • edited document, e.g. sales order, bpartner, checked Network: never had JSONDocument fields which were empty: OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants