Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Process is started twice when using ctrl-u shortcut #1324

Closed
teosarca opened this issue Nov 6, 2017 · 3 comments
Closed

Process is started twice when using ctrl-u shortcut #1324

teosarca opened this issue Nov 6, 2017 · 3 comments
Labels
branch:master branch:release priority:high

Comments

@teosarca
Copy link
Member

teosarca commented Nov 6, 2017

Is this a bug or feature request?

Bug

What is the current behavior?

Which are the steps to reproduce?

e.g.

  • open receipt candidates
  • select a line and press ctrl-u to open the HU editor (i.e. run the current quick action)
  • press ctrl-u again to receive
    => you get some weird backend error, but if u inspect the Network tab you can see that /start endpoint is called twice
    image

NOTE: if you would press the button (using mouse), the /start endpoint would be called only once

What is the expected or desired behavior?

/start endpoint shall be called only once.
pablosichert added a commit that referenced this issue Nov 6, 2017
@pablosichert
Hotfix: process starting twice when using shortcut
f38f26b 
Only activate shortcuts for the last mounted QuickActionsContextShortcuts component

Issue #1283
Issue #1324
@pablosichert pablosichert mentioned this issue Nov 6, 2017
Merged
metas-mk added a commit to metasfresh/metasfresh that referenced this issue Nov 7, 2017
@metas-mk
Update ReleaseNotes.md
02af7e1 
Adding aditional Issues to the Release of next week.
metasfresh/metasfresh-webui-frontend-legacy#1283
Revise shortcut handling
metasfresh/metasfresh-webui-frontend-legacy#1324
Process is started twice when using ctrl-u shortcut
metas-ts pushed a commit that referenced this issue Nov 7, 2017
@pablosichert @metas-ts
Hotfix: process starting twice when using shortcut
fb26c8b 
Only activate shortcuts for the last mounted QuickActionsContextShortcuts component

Issue #1283
Issue #1324

(cherry picked from commit f38f26b)
@metas-ts
Copy link
Member

metas-ts commented Nov 7, 2017

cherry-picked to 2017-11

@metas-dh
Copy link
Member

metas-dh commented Nov 8, 2017

Results of IT1
tested in mf15

/start endpoint only called once when using [ctrl]+u shortcut:

  • in receipt candidates, to create material receipt: OK
  • in picking terminal, to set HU as source HU: OK
  • in shipment schedules, to change the delivery date (was set as main action): OK

@metas-dh metas-dh closed this as completed Nov 8, 2017
@metas-ts
Copy link
Member

cherry-picked to release

metas-ts pushed a commit that referenced this issue Nov 10, 2017
@pablosichert @metas-ts
Hotfix: process starting twice when using shortcut
bd2b6ed 
Only activate shortcuts for the last mounted QuickActionsContextShortcuts component

Issue #1283
Issue #1324

(cherry picked from commit f38f26b)
metas-ts added a commit to metasfresh/metasfresh that referenced this issue Nov 10, 2017
@metas-ts
update release notes
2630308 
[#1324](metasfresh/metasfresh-webui-frontend-legacy#1324)
Process is started twice when using ctrl-u shortcut

me-45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
branch:master branch:release priority:high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@teosarca @metas-ts @pablosichert @metas-dh