Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Error with alt+space for expand #1365

Closed
metas-mk opened this issue Nov 21, 2017 · 3 comments
Closed

Error with alt+space for expand #1365

metas-mk opened this issue Nov 21, 2017 · 3 comments
Labels
branch:master branch:release priority:high type:bug

Comments

@metas-mk
Copy link
Member

Is this a bug or feature request?

Bug

What is the current behavior?

Currently, alt+space menu open collides with expand functionality. The Browser Menu opens.

Which are the steps to reproduce?

Open Sales Order Window. Add Businesspartner and mandatory fields. Press alt+space for expand.

What is the expected or desired behavior?

Alt+space shall not open the browser menu. Shall expand/ compress (toggle) the lines View.

image
@pablosichert
Copy link
Contributor

Looks like it is impossible to intercept Alt+Spacebar for Windows, since control is taken away from the browser before I can handle that key.

Would it be possible to take another combination?

pablosichert added a commit that referenced this issue Nov 22, 2017
@pablosichert
Format blacklist consistently like keymap
569d4af 
Issue #1365
pablosichert added a commit that referenced this issue Nov 22, 2017
@pablosichert
Prevent default browser action (if interceptible) for custom hotkeys
2d7a23a 
Issue #1365
pablosichert added a commit that referenced this issue Nov 22, 2017
@pablosichert
Add "Alt+Spacebar" to blacklist since it's not interceptible on Windo…
2219644 
…ws/Linux

Issue #1365
pablosichert added a commit that referenced this issue Nov 22, 2017
@pablosichert
Change hotkey for expand to mod + +
05274af 
Issue #1365
@pablosichert pablosichert mentioned this issue Nov 22, 2017
Merged
@pablosichert
Copy link
Contributor

New hotkey is Alt++

metas-mk added a commit to metasfresh/metasfresh that referenced this issue Nov 22, 2017
@metas-mk
Update ReleaseNotes.md
f58e405 
Adding a new Fix to teh release notes of next week's release
metasfresh/metasfresh-webui-frontend-legacy#1365
Error with alt+space for expand
@metas-lc metas-lc self-assigned this Nov 24, 2017
@metas-lc
Copy link

IT

  1. open new sales order, add a bpartner and press alt++
    => lines view expands OK
  2. press alt++ again
    => lines view compress OK

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
branch:master branch:release priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@metas-ts @pablosichert @metas-mk @metas-lc