Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

reload /i18n/messages in case the language changed #1616

Closed
teosarca opened this issue Feb 21, 2018 · 2 comments
Closed

reload /i18n/messages in case the language changed #1616

teosarca opened this issue Feb 21, 2018 · 2 comments

Comments

@teosarca
Copy link
Member

teosarca commented Feb 21, 2018

Is this a bug or feature request?

Bug

What is the current behavior?

Atm, the default language is German.
After user logs in, user's language is used.
Suppose your user language is not German, let's say it's English.
After you log in the static messages (those which are fetched using /i18n/messages endpoint) are still in German.

Which are the steps to reproduce?

Suppose your user's language is English (check your user profile).
Do login and inspect Chrome-Network tab.
image
image

Below are some of the places where static messages are used (just to quickly check which language is currently used):
image
image
image

etc etc etc

What is the expected or desired behavior?

Static messages shall be in user's language.

@siemiatj siemiatj self-assigned this May 31, 2018
siemiatj added a commit that referenced this issue Jun 1, 2018
metas-mk added a commit to metasfresh/metasfresh that referenced this issue Jun 5, 2018
Adds new Issue
metasfresh/metasfresh-webui-frontend-legacy#1616
Reload /i18n/messages in case the language changed
@metas-lc metas-lc self-assigned this Jun 5, 2018
@metas-lc
Copy link

metas-lc commented Jun 5, 2018

IT
logged in while user had en language
=> static messages are in EN OK
logged in while user had de language
=> static messages are in DE OK

note: after login, the language of jasper is always DE. Created task: metasfresh/metasfresh-webui-api-legacy#980

@metas-lc metas-lc closed this as completed Jun 5, 2018
@metas-ts
Copy link
Member

metas-ts commented Jun 6, 2018

🍒 picked to release

metas-ts pushed a commit that referenced this issue Jun 6, 2018
(cherry picked from commit ddba831)
metas-ts pushed a commit that referenced this issue Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants