Error indicator for fields

[metas-mk]

Type of issue

Feature Request

Current behavior

Currently, there is no error indicator for fields. There is an indicator in blue that shows if a mandatory field is empty.

Expected behavior

Have an indicator that shows an error indicator for fields that are mandatory but not filled and for other error situations of fields. The indicator should have the same color as the "not saved indicator for records. see #437
I would suggest a pale red colored line (similar to the density of pulse effect yellow but only as a line similar to mandatory field marker).
As discussed in weekly jour fix. Would be great to have an error message indicator in fields marked as error e.g. a red circled "i" for example when hovering over it then pops up an error description tooltip.

[teosarca]

see:

[cadavre]

Described in #253 .

[damianprzygodzki]

@teosarca ive implemented the respecting of valid property, but i see that there is a missing thing.

We assumed that not edited field, should be valid at first sight, but now we are mixing mandatory and valid together, what looks bad. I am waiting for that with merging this PR, in case of avoidance of propagating testing issues.

[cadavre]

Looks uber-nice for me.

@teosarca we agreed to provide valid: true as initial value? Or adding another property initialValidation: {bool}? I guess it was 1st option.

[teosarca]

@damianprzygodzki @cadavre

@teosarca we agreed to provide valid: true as initial value? Or adding another property initialValidation: {bool}? I guess it was 1st option.

Yes, u are right... but i don't have it now.
I would suggest to split this to another task so we can let this task flow... wdyt?

[damianprzygodzki]

I think that it is required, and can't be merged without that. It looks at least weird to have mandatory and not valid input at the same time, and that case is occuring really often because the mandatory fields are always empty at the start... I don't want to trigger more issues.

Imho, this task is not done til the support from API. Or we can close that, and create issue for backend - but still, it is not testable.

[teosarca]

ok, np... on it.

[teosarca]

implemented in metasfresh/metasfresh-webui-api-legacy#203 .
waiting for the build and then i will do a rollout.

NOTE: the field is called initialValue

[teosarca]

API ready

[teosarca]

Did a quick test:

• create new order
• hover bpartner and the "mandatory" error message is displayed
  => NOK because the field has it's initial value

see:

[metas-mk]

Tested Works as required. Closing.