Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

KPIs: In case datasets is empty or missing shall show "No data" text #713

Closed
teosarca opened this issue May 4, 2017 · 5 comments
Closed

Comments

@teosarca
Copy link
Member

teosarca commented May 4, 2017

Current behavior

When "/dashboard/kpis//data" returns empty or missing "datasets" field,
the KPI widget shows "Error loading data..." (red).

Expected behavior

The KPI widget shall display "No data" text (black).

But only in case the "datasets" is empty or missing.
In case of an endpoint failure, we keep it as it is, "Error loading data..." (red).

Steps to reproduce

Sorry, but you have to mock it.
Below it's a screenshot using a dev db:
image

@teosarca teosarca added this to the 2017-19 milestone May 4, 2017
@teosarca teosarca changed the title KPIs: In case datasets is empty or missing show "No data" text KPIs: In case datasets is empty or missing shall show "No data" text May 4, 2017
@metas-mk metas-mk modified the milestones: 2017-21, 2017-19 May 16, 2017
damianprzygodzki added a commit that referenced this issue May 18, 2017
damianprzygodzki added a commit that referenced this issue May 18, 2017
@metas-lc
Copy link

IT
looks the same

kpis

@damianprzygodzki
Copy link
Contributor

damianprzygodzki commented May 26, 2017

@metas-lc Where can we check this? It was working on mocked data, it will great to have opportunity to see it live.

@metasnw
Copy link
Member

metasnw commented May 27, 2017

@damianprzygodzki just get a clean metasfresh via docker compose. Here is how to: http://docs.metasfresh.org/installation_collection/EN/How_do_I_setup_the_metasfresh_stack_using_Docker.html
we are using that a lot to test on clean systems that have not been manually altered

@cadavre
Copy link
Contributor

cadavre commented May 30, 2017

Fixed.

@metas-mk
Copy link
Member

Tested. (modified Queries and Time ranges to test w101). Works as required. Done.

metas-mk added a commit to metasfresh/metasfresh that referenced this issue May 31, 2017
Adding issue/ release notes to our next release.
metasfresh/metasfresh-webui-frontend-legacy#713 KPIs: In case of datasets being empty or missing shall show "No data" text
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants