Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

frontend: JSON documents: always use "fieldsByName" instead of "fields" #773

Closed
teosarca opened this issue May 22, 2017 · 4 comments
Closed

Comments

@teosarca
Copy link
Member

Type of issue

Feature request

Expected behavior

We changed following API responses:

  • getting a single document data
  • getting view data
  • responses to document PATCHing

In all those cases we are now providing "fieldsByName" which is a map of fields indexed by their field name.
Atm we are still providing the old "fields" property, but it's deprecated. Please make sure you are not using it.

Backend task: metasfresh/metasfresh-webui-api-legacy#405

@damianprzygodzki
Copy link
Contributor

Process parameters left not changed. It is also needed, because Processes use the same Window component as other entities.

"parameters":[{"field":"AD_Image_ID",...

They should be also fieldsByName.

teosarca referenced this issue in metasfresh/metasfresh-webui-api-legacy May 25, 2017
metas-mk added a commit to metasfresh/metasfresh that referenced this issue May 31, 2017
Adding issue
metasfresh/metasfresh-webui-frontend-legacy#773) frontend: JSON documents: always use "fieldsByName" instead of "fields"
to this week's release notes.
@metas-mk metas-mk self-assigned this May 31, 2017
@metas-mk
Copy link
Member

Checked. Cannot be tested at, w/o taking out the "fields" property from the backend. waiting for that.

@teosarca
Copy link
Member Author

teosarca commented May 31, 2017

Note to IT: now this one is testable
Pls check/test on regular document, Process params, ASI and location

@metas-mk
Copy link
Member

metas-mk commented Jun 7, 2017

Tested. Checked
a) "Fields" property is not exiting anymore: OK
c) New and existing Sales Oder: OK
d) New and existing ASI in Sales Order Line: OK
e) New and existing Location: OK

Done. Closing.

@metas-mk metas-mk closed this as completed Jun 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants