Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Less version 1.4.x #65

Closed
vjpr opened this issue Jul 10, 2013 · 3 comments
Closed

Support Less version 1.4.x #65

vjpr opened this issue Jul 10, 2013 · 3 comments

Comments

@vjpr
Copy link

vjpr commented Jul 10, 2013

Could not find any mention on the website as to what less version less-rails uses.

From commit messages it appears its 1.3.3.

1.4.0 comes with the extends keyword which I need for my styles.

Is there a workaround to get 1.4.1 working with less-rails?

@metaskills
Copy link
Owner

Let's follow the dep chain. From our gemspec, you can see we rely on 'less', '~> 2.3.1'

https://github.com/metaskills/less-rails/blob/master/less-rails.gemspec#L17

The less.rb project is currently using 1.3.3.

https://github.com/cowboyd/less.rb/issues?page=1&state=open

So we have to start there and go upward. If you want to help and test, that project should allow you to update the git submodule for less and run the tests. Then you can open an issue/pr based on that.

@vjpr
Copy link
Author

vjpr commented Jul 20, 2013

Thanks. Managed to get it working for my immediate purposes. I'll run tests and submit a pull soon.

Here is an interim solution for anyone interested:

gem 'commonjs', :git => 'git://github.com/vjpr/commonjs.rb', :branch => 'fix-require'
gem 'less', :git => 'git://github.com/vjpr/less.rb', :branch => '1.4.1', :submodules => true
gem 'less-rails' 

If you are using https://github.com/seyhunak/twitter-bootstrap-rails you will need the following which includes Less 1.4.x compatible Bootstrap files:

gem 'twitter-bootstrap-rails', git: 'https://github.com/seyhunak/twitter-bootstrap-rails.git', branch: 'master'

@metaskills
Copy link
Owner

This is done now in our 2.4.x versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants