Support screenshots #165
Merged
Support screenshots #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test too? thanks. Take a look at some of the |
|
Hi, I'll definitely simplify the impl and add a test as soon as I get a suitable timeslot for that. Thanks for timely response! |
|
There you go! I added a simple test for the existence of the expected screenshot file. After test, the file is deleted. |
nathanboktae
added a commit
that referenced
this pull request
Dec 4, 2014
Support screenshot capturing
|
Thanks for the contribution! |
|
You're very welcome. Thanks for your good work on mocha-phantomjs! |
|
Love this feature, awesome work y'all! |
|
I just published and tagged v3.5.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #130, now you can take screenshots in your tests.
See the updated README.md for details.