Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUnrealObjectPropertyDecorator GetCPPType #23

Open
ganibc opened this issue May 18, 2023 · 1 comment
Open

FUnrealObjectPropertyDecorator GetCPPType #23

ganibc opened this issue May 18, 2023 · 1 comment
Assignees

Comments

@ganibc
Copy link

ganibc commented May 18, 2023

Hi,

Why the code is like this:

FString FUnrealObjectPropertyDecorator::GetCPPType()
{
	return TEXT("UObject*");
}

Instead of

FString FUnrealObjectPropertyDecorator::GetCPPType()
{
	return OriginalProperty->GetCPPType();
}

I feel the current code is maybe error prone, since TObjectPtr or TWeakObjectPtr both are translated to UObject*.
There's no guarantee both are saving UObject* directly.
I haven't read through their implementation, but it seems TWeakObjectPtr is not saving pointer value, instead if it save ObjectIndex to query GUObjectArray.

@Augkit
Copy link
Collaborator

Augkit commented May 20, 2023

ChanneldUE does not yet support TWeakObjectPtr, but has created an issue #26 and is welcome to join the development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants