Skip to content
This repository has been archived by the owner on Mar 21, 2021. It is now read-only.

add MaterialDesign as submodule and add empty folder for icons to pre… #8

Closed
wants to merge 10 commits into from

Conversation

mueller-ma
Copy link
Contributor

…vent python expections

This PR creates folder that will stay empty on github

Kind of a fix for #6
Fix #3

@metbril
Copy link
Owner

metbril commented Sep 1, 2017

Awesome.

Question. I do not have in depth knowledge of git. Since I'd like to try your changes locally, how can I pull your PR into it's own branch?

@mueller-ma
Copy link
Contributor Author

git remote add mueller-ma https://github.com/mueller-ma/openhab-mdi
git fetch mueller-ma
git checkout mueller-ma/master
git submodule update

Than you should have my master branch as local branch with the mdi as git module

@mueller-ma
Copy link
Contributor Author

Hey @metbril
Did you have some time to look into this?

@mueller-ma
Copy link
Contributor Author

This PR was made from my master. I want to get some things done, but making a PR for every change really slows the development, so I merged everything in my master and try to fix the current issues. After that I can make one big PR, so all changes are in your repo. Does that sound good to you?

@mueller-ma mueller-ma closed this Feb 23, 2018
@metbril
Copy link
Owner

metbril commented Feb 23, 2018

You are the first one ever to submit a pr to one of my repos. I'm a git novice so I will have a look at it, since I did some work myself that has not yet been pushed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed MDI repository
2 participants