feat: initial commit #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruczyna
reviewed
Aug 5, 2022
|
|
||
| await logging.init() | ||
|
|
||
| const stream = split(logging.parseLine.bind(logging), { autoDestroy: true }) |
There was a problem hiding this comment.
I am a bit confused here:
logging.parseLine.bind(logging),
Why do we borrow and assign logging to logging? 🤔
There was a problem hiding this comment.
It's just to inject the function without losing the context of the this.
If I just borrow the function, the parseLine uses the this to access a couple of helper functions and the Logging instance, all of the previous will be lost if I don't properly hard-bind the logging instance to the bind function itself
kruczyna
approved these changes
Aug 5, 2022
|
Let's merge and continue with adding testing in a next PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR for cloud-pine