Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog does not pull in "not found" template (flow router) #272

Open
deborah-ufw opened this issue May 26, 2016 · 2 comments
Open

blog does not pull in "not found" template (flow router) #272

deborah-ufw opened this issue May 26, 2016 · 2 comments

Comments

@deborah-ufw
Copy link

deborah-ufw commented May 26, 2016

Blog presents empty content where "not found" content should be.

  • using FlowRouter
  • in FlowRouter routes, a default "not found" route is specified
  • it works in the rest of the app
  • blog is using a custom BlogPost.html
  • the custom BlogPost.html is located in the same client/templates folder as the error-404.html template
  • did not specify anything, but blog did not use the FlowRouter "not found" route
  • tried specifying blogNotFoundTemplate: 'error-404', in blog-config.js but it didn't work

Tried changing the template name from "error-404" to "error404", adjusting references and re-testing, but it still did not work.

@deborah-ufw deborah-ufw changed the title blog does not pull in "not found" template specified in blog config (flow router) blog does not pull in "not found" template (flow router) May 26, 2016
@foobarbecue
Copy link

I've been trying to understand meteor-blog's router recently (in router.coffee). Would be great if there's a dev here who can explain it.

It seems it's not really using flow-router or iron-router for the actual routing. I'm using flow-router, and meteor-blog registers a single route for the url pattern /:any* and then seems to do the actual routing "manually." Unless I'm misunderstanding something, this seems like a very bad way of doing things and it's probably the reason that 404s are mishandled. Can anybody confirm or deny?

@hellogerard
Copy link
Contributor

@foobarbecue This is true. This was the only way to support both routers at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants