Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow packages that rely on fourseven:scss to add an include path #40

Closed
reywood opened this issue Sep 3, 2014 · 3 comments
Closed

Comments

@reywood
Copy link
Contributor

reywood commented Sep 3, 2014

This is an idea to make it easier for users to include partials provided by other packages such as reywood:bootstrap3-sass or matthew:foundation5-sass. Currently, the user has to include something along the lines of @import '.meteor/local/build/programs/server/assets/packages/reywood:bootstrap3-sass/bootstrap'; in their scss file to use these packages. One problem with this is that some systems apparently have an underscore instead of a colon in the path.

Here's a half baked idea I came up with to maybe solve this problem. In a package that relies on fourseven:scss, one would include a JS file on the server (i.e. api.addFiles([ "include-path.js" ], "server")). In that file, they would have something like Scss.addIncludePath("path/to/reywood:bootstrap3-sass"), and meteor-scss could push that value onto the includePaths array option. Then users could just add @import 'bootstrap'; to their scss file. I haven't quite figured out how to get the real path to the package in a consistent way, but figured this would be food for thought.

@jadsonlourenco
Copy link

+1

1 similar comment
@bompi88
Copy link

bompi88 commented Jun 27, 2015

+1

@sebakerckhof
Copy link
Collaborator

3.4.0-beta1 supports cross-package imports for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants