-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maps do not work #44
Comments
Hey Knotix, This package uses LibSass, which does not support the latest and greatest Sass 3+ features. You can review a brief discussion about it in the Meteor Google Group here: https://groups.google.com/forum/#!topic/meteor-talk/FD1PmAAFDaQ |
Thanks @aaronagray, and yes, unfortunately that syntax isn't yet supported with this project. I'll add a note on the readme before closing this issue. |
@fourseven Have you thought about supporting an optional config file that could point to the Ruby installation of Sass? |
Hi @Knotix - Honestly, I have no interest in adding support for Ruby's Sass implementation. Feel free to make another meteor package if you absolutely require it, but I disagree with expecting Ruby in Node/Javascript projects. |
I agree that Ruby inside of a Node project feels strange. It's possible that LibSass will announce Sass 3.x+ features at SassConf this week, as large announcements are historically reserved until this event. I'll be there and will report back here if / as soon as anything like that comes up. :) |
@Knotix: Libsass announced maps and extends yesterday and merged them into master RC. There is limited support for looping through maps, but it's 95% there. @fourseven: Is there anything fancy we need to do to test the RC in fourseven? |
I need to check on node-sass, once that's updated we're good to go |
Here's the node-sass issue to follow: sass/node-sass#444 |
@fourseven what's the status on this? The issue sass/node-sass#444 has been closed and the fix merged. |
Hi @PikaDotus, et. al. - it needs more development, I will give that a go tonight and see how I get on, last time the meteor asset toolchain wasn't being friendly. |
@fourseven are source maps working yet? |
hi @keyvanfatehi - no they're not, libsass still has issues generating them, which look to be improved in v3.2. node-sass is using v3.1 of libsass in their 2.0.0 beta, so it might be a while yet unfortunately. |
too bad. i wanted to ask this as well. although it seems to be fixed in libsass 3.1.0-beta btw, a bit OOT, but i tried switching to grigio:ruby-sass. but i'm getting this error even though i already removed your package.
|
Create a file with the following:
The error reported is:
The text was updated successfully, but these errors were encountered: