Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router jumps to home page if login dialog is used in a modal #12

Closed
derwaldgeist opened this issue Sep 21, 2015 · 7 comments
Closed

Router jumps to home page if login dialog is used in a modal #12

derwaldgeist opened this issue Sep 21, 2015 · 7 comments

Comments

@derwaldgeist
Copy link

I am using the approach of @Maxhodges to use the login dialog in a modal dialog, like explained here:
meteor-useraccounts/bootstrap#25

Yet, every time the user logs in, flow router automatically jumps to the home page of my application instead of staying on the current page. It does not behave this way if I am using the standard full-page login dialog, so my flow router configuration seems to be correct and it must have something to do with the useraccounts package itself (either core or flowrouting).

@Maxhodges
Copy link

i think you can set that

see
"homeRoutePath" in le guide

https://github.com/meteor-useraccounts/core/blob/master/Guide.md

@splendido
Copy link
Member

For useraccounts:iron-routing it's enough to set AccountsTemplates.avoidRedirect to true to solve this issue: see this line

At the moment that's not the same for useraccounts:flow-routing: see this line
I see there's an avoidDefaultRefirect here and here but actually it's never initialized...

@jshimko do you have any memory about this change we had during the split of routing stuff?

Should we rename avoidDefaultRedirect back to avoidRedirect (which is initialized here btw...) and modify the link click to be alike the one we have for IR?

@derwaldgeist
Copy link
Author

Thanks for taking action on this, highly appreciated!

@jshimko
Copy link
Member

jshimko commented Sep 22, 2015

@splendido @derwaldgeist Yeah, I guess that one just flew under the radar when we were making the conversion. I'll take a closer look and see if I can get it sorted out.

@derwaldgeist
Copy link
Author

Thanks for picking this up!

@splendido
Copy link
Member

This should be solved now, thanks @jshimko!

@derwaldgeist
Copy link
Author

Oh, great, will have a look at it! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants