Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meteor data not triggering watch and computed dependencies (v2.0.0-beta.3) #34

Closed
mizzao opened this issue Jul 2, 2018 · 4 comments
Closed

Comments

@mizzao
Copy link

mizzao commented Jul 2, 2018

After updating from v1.2.3, I am much happier about the cleaner code and reduction of redundant data keys. However, there are a couple of Vue modules that are no longer working as before and I tracked them down to having watch and computed values that depend on the keys that were previously listed in data() { return { foo: ... } } but are now generated by meteor: { foo: ... }.

All template code that depends on the meteor data keys still work fine.

Is this a bug or something I'm doing wrong? Happy to create a reproduction but wanted to quickly check if this was an actual issue first.

EDIT: just saw that the computed code was added in beta.3. Maybe it needs some tests :)

@mizzao
Copy link
Author

mizzao commented Jul 19, 2018

@Akryum, is this an actual issue or did I do something wrong?

@mitar
Copy link
Member

mitar commented Sep 13, 2018

(Just to shamelessly plug an alternative here, which is to use Tracker ported to Vue reactivity, as described here.)

@mizzao
Copy link
Author

mizzao commented Sep 13, 2018

@mitar I trust all your products, but does that package do everything that this one does, or something slightly different?

Why don't you publish it on NPM instead of requiring someone to check out a submodule?

@mizzao mizzao closed this as completed Sep 13, 2018
@mizzao mizzao reopened this Sep 13, 2018
@mitar
Copy link
Member

mitar commented Sep 13, 2018

It does it in a different way (requires Vue fork). To my understanding it provides the same features, but with different approach.

Why don't you publish it on NPM instead of requiring someone to check out a submodule?

meteor/meteor-feature-requests#47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants