Skip to content
This repository has been archived by the owner on Jun 29, 2021. It is now read-only.

Add an ETag header #176

Closed
radekmie opened this issue Sep 6, 2017 · 4 comments
Closed

Add an ETag header #176

radekmie opened this issue Sep 6, 2017 · 4 comments

Comments

@radekmie
Copy link
Collaborator

radekmie commented Sep 6, 2017

What do you think about serving an ETag header? It's not a big deal, but it can reduce the server load a bit, because browser can cache responses. It's kind of more important now, as Meteor have a cleaner way to SSR.

It'll probably be fairly easy: just use etag (express is using it) in the webapp/webapp_server.js, right before res.end().

@hwillson
Copy link
Contributor

hwillson commented Sep 7, 2017

This should already be supported for static files @radekmie - see https://github.com/meteor/meteor/blob/0d7ce023e0902094305960fd5d1268e21702a9f3/packages/webapp/webapp_server.js#L458. Is something not working properly?

@hwillson
Copy link
Contributor

hwillson commented Sep 7, 2017

Unless you mean generate and set an etag for every response (so not just static files). That isn't currently supported, and might be nice to add.

@radekmie
Copy link
Collaborator Author

radekmie commented Sep 7, 2017

Yes, I know that. I meant every response. At least the HTML.

@radekmie
Copy link
Collaborator Author

It’s already possible. Great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants