Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refreshing triggers bugs #3

Closed
benstr opened this issue Jan 8, 2015 · 2 comments
Closed

Refreshing triggers bugs #3

benstr opened this issue Jan 8, 2015 · 2 comments

Comments

@benstr
Copy link
Member

benstr commented Jan 8, 2015

When refreshing the bottom navbar resets the active class to Trending page.

When refreshing while on Notifications or Profile pages Log-In modal pops up whether you are logged in or not. Should only show when not logged in.
@nickw
Copy link

nickw commented Jan 8, 2015

Ah right:

  1. Re: refreshing…we need to figure out a way to "activate" the current tab when the page loads. Currently the tab is activated when it is clicked: https://github.com/meteoric/meteor-ionic/blob/master/components/ionTab/ionTab.js#L2. And I just put in an ugly hack to activate the first tab when the app loads: https://github.com/meteoric/meteorhunt/blob/master/client/templates/layouts/appLayout.js#L2
  2. Re: login modals. I think we just need to check Meteor.loggingIn()

@benstr
Copy link
Member Author

benstr commented Jan 8, 2015

It is less elegant but what if we just set the currentTab session in the route's action hook?

@nickw nickw mentioned this issue Jan 9, 2015
Closed
@davidwoody davidwoody reopened this Jan 10, 2015
@nickw nickw closed this as completed Jan 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickw @davidwoody @benstr