Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to provide GitLab Implicit Grant #22

Closed
timaschew opened this issue Mar 22, 2019 · 7 comments
Closed

Consider to provide GitLab Implicit Grant #22

timaschew opened this issue Mar 22, 2019 · 7 comments
Labels
bitbucket Issues about Bitbucket feature Feature request gitlab Issues about GitLab

Comments

@timaschew
Copy link

GitLab provides an Implicit Grant which doesn't require to expose any clientSecret.

Netlifycms is using it for instance:
https://www.netlifycms.org/docs/authentication-backends/#gitlab-backend

@meteorlxy
Copy link
Owner

meteorlxy commented Mar 23, 2019

Thanks for advice, this could be an optional feature.

We should add an option to allow user enable it, or to set options for a certian platform / api.

E.g.:

options: {
  api: GitlabV4,
  apiConfig: { authType: 'token' },
}

https://docs.gitlab.com/ce/api/oauth2.html#implicit-grant-flow

@meteorlxy meteorlxy added feature Feature request gitlab Issues about GitLab labels Mar 23, 2019
@meteorlxy
Copy link
Owner

After some consideration, I think we could make it as the default behavior of GitLab API.

I'll try to implement it in the next minor version.

Could you please give some further advice on that? 😄 @timaschew

@meteorlxy
Copy link
Owner

I didn't notice that both GitLab and Bitbucket have supported Implicit Grant Type, and only GitHub does not support it yet.

(At first I mainly use the GitHub API to determine how the Vssue flow works)

@meteorlxy
Copy link
Owner

Close in v0.8.0

@timaschew
Copy link
Author

Wow, that was fast! Great job!

@timaschew
Copy link
Author

BTW: I cannot see any comments until I login for GitLab, for every other provider it works.
Not sure if this behaviour was present before 0.8.0 or not.

@meteorlxy
Copy link
Owner

You can check the supported-platform page in the docs. GitLab requires login to get the comments (strange, though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitbucket Issues about Bitbucket feature Feature request gitlab Issues about GitLab
Projects
None yet
Development

No branches or pull requests

2 participants