Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layering returns different results for the same dataset #30

Closed
fpavogt opened this issue Dec 20, 2021 · 1 comment · Fixed by #29
Closed

Layering returns different results for the same dataset #30

fpavogt opened this issue Dec 20, 2021 · 1 comment · Fixed by #29
Assignees
Labels
bug Something isn't working

Comments

@fpavogt
Copy link
Member

fpavogt commented Dec 20, 2021

Describe the bug
ncom_from_gmm() was found to return a different number of best_ncomp for certain datasets, if run multiple times.

This was related to the lack of fixed random seeds in the code, which leads to different results for "borderline" datasets: specifically, very thin groups that have a nearly quantized distribution of hits.

Expected behavior
The code should always return the same number of layer components.

@fpavogt fpavogt added the bug Something isn't working label Dec 20, 2021
@fpavogt fpavogt self-assigned this Dec 20, 2021
@fpavogt
Copy link
Member Author

fpavogt commented Dec 20, 2021

Fixed by specifying a random seed in the code (optionally set by the user).

fpavogt added a commit that referenced this issue Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant