Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MSA a scientific variable #34

Closed
fpavogt opened this issue Dec 21, 2021 · 0 comments · Fixed by #35
Closed

Make MSA a scientific variable #34

fpavogt opened this issue Dec 21, 2021 · 0 comments · Fixed by #35
Assignees
Labels
todo Something that devs agree should be done

Comments

@fpavogt
Copy link
Member

fpavogt commented Dec 21, 2021

Describe the change
Currently, msa is only a keywords applied to the functions issuing metars. However, cropping very high measurements prior to feeding them to the ampycloud algorithm does impact its outcome, by allowing for thinner slices.

To ease this, we need to create two new parameters: MSA and MSA_HIT_BUFFER.
The former is meant to be the official MSA value of the site, and the latter is a (positive) altitude buffer above which hits will not be considered by the ampycloud algorithm.

In p[articular, there should be a test setup to verify that MSA_HIT_BUFFER is postitive.

@fpavogt fpavogt added the todo Something that devs agree should be done label Dec 21, 2021
@fpavogt fpavogt self-assigned this Dec 21, 2021
fpavogt added a commit that referenced this issue Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo Something that devs agree should be done
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant