Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@Counter is registered as @Observer #26

Closed
Sceri opened this issue Feb 21, 2022 · 1 comment · Fixed by #27
Closed

@Counter is registered as @Observer #26

Sceri opened this issue Feb 21, 2022 · 1 comment · Fixed by #27
Labels
under-investigation

Comments

@Sceri
Copy link

Sceri commented Feb 21, 2022 •
edited

The DecoratorObserverMetricInjector and DecoratorCounterMetricInjector lack checks for decorator type in some places. Because of this @Counter functions can register as @Observer and export Histogram instead of Counter

The opposite situation is also possible, I think
@MetinSeylan MetinSeylan mentioned this issue Feb 26, 2022
Merged
@MetinSeylan
Copy link
Owner

@Sceri thanks for feedback, #27 merged

@MetinSeylan MetinSeylan linked a pull request Feb 26, 2022 that will close this issue
Hotfix observer decorators #27
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
under-investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hotfix observer decorators MetinSeylan/Nestjs-OpenTelemetry
2 participants
@MetinSeylan @Sceri