Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Parent span duration is not correctly calculated #68

Open
ikovac opened this issue Jun 30, 2023 · 1 comment
Open

Bug: Parent span duration is not correctly calculated #68

ikovac opened this issue Jun 30, 2023 · 1 comment

Comments

@ikovac
Copy link

ikovac commented Jun 30, 2023

As you can see on the screenshot below, the parent span duration is not calculated correctly.
Parent span (provider->identityservice.get) should also include the duration of child spans in its own duration. The same goes for controller->identitycontroller.profile.
I am using nestjs version 9 and zipkin in order to visualize traces.

Screenshot 2023-06-30 at 13 41 09

I think the issue is in this line: https://github.com/MetinSeylan/Nestjs-OpenTelemetry/blob/main/src/Trace/Injectors/BaseTraceInjector.ts#L68C13-L68C13
because this issue occurs with async functions. There should be other check to determine if the function is async.

@Yuuki-Sakura
Copy link

You can use my version https://github.com/Yuuki-Sakura/nestjs-open-telemetry
I fixed a lot of bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants