Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param detection in request paths #151

Open
ZeRego opened this issue Nov 28, 2022 · 1 comment
Open

Param detection in request paths #151

ZeRego opened this issue Nov 28, 2022 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@ZeRego
Copy link

ZeRego commented Nov 28, 2022

How does Metlo detect params?

Some request paths are marked with incorrect parameters.

The current path in Metlo:
/api/{param1}/org/{param2}
Expected
/api/{param1}/org/onboardingStatus

Route source: https://github.com/lightdash/lightdash/blob/e6057c27c37659235e1617527e8a6e27881ee9bc/packages/backend/src/routers/organizationRouter.ts#L176

Could it use the express routes to detect the params instead of using some magic logic? It can even detect what is the name of the param instead of using generic param1 param2 etc
eg: /user/:userUuid -> /user/{userUuid}

@shrisukhani shrisukhani added the question Further information is requested label Nov 28, 2022
@akshay288
Copy link
Contributor

Hey! Yes, we're working on that :) Currently our endpoint detection is based on some "magic" in the backend but we'll push this down to the agent level soon with our new agents... This update will also come with configurable blocking at the agent level for malicious traffic as well :) This will be coming out sometime next week and I'll update here once its ready.

I know this isn't ideal but for now you can upload Open API specs manually on the Open API Specs Tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants