Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware -> Interceptors #3

Open
ikitommi opened this issue Oct 12, 2017 · 2 comments
Open

Middleware -> Interceptors #3

ikitommi opened this issue Oct 12, 2017 · 2 comments
Labels
enhancement

Comments

@ikitommi
Copy link
Member

Eines calls things middleware, but they are more like Pedestal interceptor.

  • rename to interceptor
  • rename :in & :out to :enter & :leave?
@ikitommi
Copy link
Member Author

Also, :middleware is plural, not :middlewares.

@ikitommi
Copy link
Member Author

Interceptors should also handle thrown errors, e.g. :error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ikitommi