Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention adding metrics-graphics #34

Open
armenzg opened this issue Jul 31, 2018 · 2 comments
Open

Mention adding metrics-graphics #34

armenzg opened this issue Jul 31, 2018 · 2 comments

Comments

@armenzg
Copy link

armenzg commented Jul 31, 2018

If you just add react-metrics-graphics and try to use it as indicated in the README.md it won't work.

You will get this issue:

ERROR in ./node_modules/react-metrics-graphics/build/MetricsGraphics.js
Module not found: Error: Can't resolve 'metrics-graphics/dist/metricsgraphics.css' in '/Users/armenzg/repos/js-perf-dashboard/node_modules/react-metrics-graphics/build'

metrics-graphics is the peerDependency that is least likely to already be on a project, thus, it would be worth mention adding it to the docs.

@relistan
Copy link

@armenzg this saved me hours.

@wlach
Copy link
Collaborator

wlach commented Aug 28, 2020

Thanks @armenzg for this report, not sure how I missed it! I'm reluctant to change anything about this repository right now, as it's out of sync with metrics-graphics as it stands and not maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants