Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing write function signatures #3

Open
metroid-maniac opened this issue Mar 22, 2023 · 6 comments
Open

Missing write function signatures #3

metroid-maniac opened this issue Mar 22, 2023 · 6 comments

Comments

@metroid-maniac
Copy link
Owner

metroid-maniac commented Mar 22, 2023

Some function signatures for SRAM writes seem to not yet be detected by the patcher like Pokemon and Final Fantasy Tactics Advance. Support for the function signatures in these games will need to be added.

@metroid-maniac
Copy link
Owner Author

Write signature for Pokemon Ruby has now been added, unknown if others needed?

@metroid-maniac
Copy link
Owner Author

metroid-maniac commented Mar 25, 2023

Looks like Rhythm Tengoku uses a variant that runs in RAM, will need to patch this one too. Containing function is at 4c8b0

EDIT: looks like the function at that address is a better target, currently the signature is for the subroutine that runs from RAM

@metroid-maniac
Copy link
Owner Author

metroid-maniac commented Apr 8, 2023

Tony Hawk Pro Skater 2 reported not working (EEPROM_V111)

Quickfixed.

@metroid-maniac
Copy link
Owner Author

The save hook does not trigger in Yu-Gi-Oh! Reshef of Destruction.

@metroid-maniac
Copy link
Owner Author

For some reason, the exact same write function is repeated twice consecutively at 58760 and 587a0 in Yu-Gi-Oh! Reshef of Destruction. The patcher only catches the first one right now.

@metroid-maniac
Copy link
Owner Author

Yu-Gi-Oh Reshef and Castlevania Double Pack should be fixed with 1a27162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant