-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model_summary() Intermediate Printout #23
Comments
Update: this appears to be related to a change in the last PR into
|
seth and i discussed that this morning some, I think this model_summary needs an overhaul. Here is what I am thinking - model_summary() should only work if the model is completed.
the reason that waiting should be moved outside of specific submission is this allows composability and other customization. For example, maybe we want to provide a wait function that also has enough logic to know about failures - basically a specific tryCatch
|
that seems like a reasonable expectation to me. if you're pulling out |
@callistosp this will be closed when the linked PR merges. The fix is that model_summary() just stops with an informative error if it can't get a summary (see tests mentioned below). We are intending to make a better version of If you have thoughts on how you would like that to work, like some of the ones you put in the comments above, you can open a new issue with the desired functionality and tag it with the milestone Tests
|
We're closing this because there is another issue to deal with this: |
Problem:
When a model is still running and
model_summary()
is called on the results objects, the OUTPUT is tailed multiple times until either 1) the model completes, or 2) number of attempts (30?) is exceeded. This results in the tail of the OUTPUT being continuously printed to console.Proposed solution:
If model is still running, tail of OUTPUT should only be printed a single time.
The text was updated successfully, but these errors were encountered: