Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messy code formatting and documentation #38

Open
barrettk opened this issue Mar 1, 2024 · 0 comments
Open

Messy code formatting and documentation #38

barrettk opened this issue Mar 1, 2024 · 0 comments

Comments

@barrettk
Copy link

barrettk commented Mar 1, 2024

Was looking through this file and noticed a lot of the code is poorly formatted and commented.

  • There is code at the bottom with library calls commented out. This shouldnt be in main
  • Most of the comments were ported over from PKPDmisc, though I think they should be rewritten a bit more from a developer perspective rather than a scientist one (example)
  • Code and comment indentation and new lines are odd in a few cases (example)
  • The title for resample_df is just "resampling", which seems a bit lacking

I haven't looked at other scripts, but I doubt these issues are unique to this one. Would suggest running styler and fixing some other code/comment/message formatting mentioned above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant