Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass SIGMA into model functions #1051

Merged
merged 2 commits into from Feb 10, 2023
Merged

Pass SIGMA into model functions #1051

merged 2 commits into from Feb 10, 2023

Conversation

kylebaron
Copy link
Collaborator

@kylebaron kylebaron commented Feb 7, 2023

Summary

This PR implements the ability to access on diagonal elements of SIGMA in the model functions.

The data are stored as a numeric vector in self.SIGMA. This is zero- based indexing. There is 1-based indexing through the SIGMA() macro (see unit test).

Copy link

@timwaterhouse timwaterhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, you're fast. This looks good, thanks.

@kylebaron kylebaron self-assigned this Feb 7, 2023
@kylebaron kylebaron added this to Evaluate in Development Feb 7, 2023
@kylebaron kylebaron linked an issue Feb 7, 2023 that may be closed by this pull request
@kylebaron kylebaron merged commit b22bcaf into develop Feb 10, 2023
Development automation moved this from Evaluate to Done Feb 10, 2023
@kylebaron kylebaron deleted the pass-sigma branch February 10, 2023 03:34
This was referenced Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
Done
Development

Successfully merging this pull request may close these issues.

Access SIGMA(n) in model functions
2 participants